Remove incorrect annotation on GitSCM.getBrowser() #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesse Glick notes in https://issues.jenkins.io/browse/JENKINS-75288: > adding @Whitelisted to a method already marked @OverRide is clearly > a mistake—this would never have any effect. I didn't realize that was a mistake when I added the annotation. Let's remove the annotation so that the code does not mislead someone to think that this can be used from a Pipeline without changes to hudson.scm.SCM.getBrowser(). In a multibranch Pipeline, the default checkout assigns current values to the scm object, including scm.browser. That value can't be read unless the hudson.scm.SCM.getBrowser() method is approved through script security.
MarkEWaite
added
the
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove incorrect annotation on GitSCM.getBrowser()
Jesse Glick notes in JENKINS-75288:
I didn't realize that was a mistake when I added the annotation. Let's remove the annotation so that the code does not mislead someone to think that this can be used from a Pipeline without changes to hudson.scm.SCM.getBrowser().
In a multibranch Pipeline, the default checkout assigns current values to the scm object, including scm.browser. That value can't be read unless the hudson.scm.SCM.getBrowser() method is approved through script security.
Testing done
None. Already confirmed that the annotation has no effect, as noted in JENKINS-75288. Removing the annotation will continue to have no effect.
Submitter checklist